Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR to main] DESENG-483 - Adding missing unit test #2394

Merged
merged 15 commits into from
Feb 26, 2024
Merged

Conversation

ratheesh-aot
Copy link
Collaborator

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-483

Description of changes:

Feature branch PR's

[PR] #2384 Merged

[PR] #2387 Merged

[PR] #2390 Merged

[PR] #2391 - Merged

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@Baelx Baelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (c5f9a93) to head (d2e5e80).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   71.25%   73.55%   +2.30%     
==========================================
  Files         509      516       +7     
  Lines       17074    17584     +510     
  Branches     1289     1344      +55     
==========================================
+ Hits        12166    12934     +768     
+ Misses       4669     4441     -228     
+ Partials      239      209      -30     
Flag Coverage Δ
metweb 63.98% <ø> (+4.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/engagement/form/EngagementWidgets/Poll/Form.tsx 80.76% <ø> (+60.57%) ⬆️
...orm/EngagementWidgets/Poll/PolllAnswerItemForm.tsx 90.90% <ø> (+45.45%) ⬆️

... and 62 files with indirect coverage changes

@ratheesh-aot ratheesh-aot merged commit 85599f2 into main Feb 26, 2024
8 checks passed
@ratheesh-aot ratheesh-aot deleted the DESENG-483-FINAL branch February 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants